Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup release automation #57

Merged
merged 3 commits into from
Jun 17, 2024
Merged

chore: setup release automation #57

merged 3 commits into from
Jun 17, 2024

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jun 4, 2024

Fixes: #56
Refs: nodejs/gyp-next#248

@MoLow
Copy link
Member Author

MoLow commented Jun 4, 2024

@cclauss @jbergstroem can you please add https://pypi.org/user/nodejs-foundation/ as a maintainer of https://pypi.org/project/tap2junit/?

@legendecas
Copy link
Member

legendecas commented Jun 4, 2024

The OIDC publishing needs configurations on https://pypi.org/manage/project/tap2junit/settings/publishing/. Such as:

Repository: [nodejs/tap2junit](https://github.com/nodejs/tap2junit)
Workflow: release-please.yml
Environment name: pypi

@MoLow
Copy link
Member Author

MoLow commented Jun 5, 2024

The OIDC publishing needs configurations on pypi.org/manage/project/tap2junit/settings/publishing. Such as:

Repository: [nodejs/tap2junit](https://github.com/nodejs/tap2junit)
Workflow: release-please.yml
Environment name: pypi

ping @cclauss @jbergstroem - if you have concerns or objections please raise them.
other repos and tools in the nodejs org depend on this tool and we need a way of publishing it, and if you object giving the org access please let us know so we can find an alternative way to distribute this package

@legendecas
Copy link
Member

legendecas commented Jun 17, 2024

Thank you @cclauss for adding nodejs-foundation as a co-owner! I have setup the OIDC connection and this should be ready to go when all the suggestions are addressed.

@MoLow
Copy link
Member Author

MoLow commented Jun 17, 2024

@cclauss and @legendecas thanks for your help!

@MoLow MoLow requested review from legendecas and aduh95 June 17, 2024 11:08
@MoLow MoLow requested a review from legendecas June 17, 2024 11:24
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it and adapt in a follow up if something's missing 👍

@MoLow MoLow merged commit 65e2222 into main Jun 17, 2024
1 check passed
@MoLow MoLow deleted the add-release-workflow branch June 17, 2024 13:05
@MoLow
Copy link
Member Author

MoLow commented Jun 17, 2024

release worked. thanks all for helping out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add publishing credentials to repo secrets
4 participants