feat: change timeouts to 120 seconds

[kyrylkov]

No description provided.

[mcollina]

lgtm

We will ship this when we cut a new major.

[ronag]

If prefer if we only change this for fetch.

[kyrylkov]

@ronag I looked through fetch code but I wasn't able to figure out how to change timeouts there. Also for server requests 30 seconds is just too short. We deal with lots of long running requests and that's how we ran into this problem in the first place.

[ronag]

@ronag I looked through fetch code but I wasn't able to figure out how to change timeouts there.

You can pass timeout in the .dispatch call in the fetch code.

Also for server requests 30 seconds is just too short. We deal with lots of long running requests and that's how we ran into this problem in the first place.

I disagree and would prefer the 30 second. Maybe you could change my mind but I would need some more convincing.

[kyrylkov]

I disagree and would prefer the 30 second. Maybe you could change my mind but I would need some more convincing.

30 second timeout exists only in Firefox. Node default timeout is 120. Chrome is 300.

Otherwise why 30? Why not 10? There should be some consistency. Aligning with Node or Chrome seems like a good idea.

[ronag]

Node default timeout is 120.

As far as I can see from the code and docs there is no default timeout for Node?

To be clear I'm fine with changing the timeout for fetch. Just not undici in general as I think 30s is a much more useful timeout for a server workload. Changing the timeout for fetch is something we can land without semver major.

[kyrylkov]

@ronag Then how about another PR for fetch timeout for 300 seconds (like in Chrome)?

[ronag]

@ronag Then how about another PR for fetch timeout for 300 seconds (like in Chrome)?

SGTM!