Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fetch): remove unnecessary checks #1520

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Conversation

KhafraDev
Copy link
Member

Webidl conversions/checks are done in the Request constructor, so the checks in the fetch function were unnecessary.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a87242f into nodejs:main Jun 30, 2022
@KhafraDev KhafraDev deleted the fetch-webidl branch June 30, 2022 07:06
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants