Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't headersTimeout while writing request body #646

Merged
merged 8 commits into from
Apr 4, 2021
Merged

fix: don't headersTimeout while writing request body #646

merged 8 commits into from
Apr 4, 2021

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 30, 2021

Fixes: #645

@ronag

This comment has been minimized.

Sign in to view
@ronag ronag force-pushed the fix-headers-timeout branch 3 times, most recently from c563780 to 285f6bc Compare March 30, 2021 13:05
@codecov-io
Copy link

codecov-io commented Mar 30, 2021 •
edited

Codecov Report

Merging #646 (5a12d10) into main (002b2bc) will decrease coverage by 0.54%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
- Coverage   97.24%   96.70%   -0.55%     
==========================================
  Files          25       25              
  Lines        1998     2004       +6     
==========================================
- Hits         1943     1938       -5     
- Misses         55       66      +11
Impacted Files Coverage Δ
lib/client.js 98.51% <94.11%> (+0.01%) ⬆️
lib/agent.js 75.86% <0.00%> (-7.76%) ⬇️
lib/mock/mock-agent.js 96.55% <0.00%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002b2bc...5a12d10. Read the comment docs.

@ronag ronag added this to the 4.0 milestone Mar 31, 2021
@ronag ronag self-assigned this Apr 1, 2021
@ronag ronag requested review from mcollina and dnlup April 2, 2021 10:56
@ronag ronag marked this pull request as ready for review April 2, 2021 10:57
@ronag ronag marked this pull request as draft April 2, 2021 10:58
@ronag ronag added the semver-major Features or fixes that will be included in the next semver major release label Apr 2, 2021
dnlup
dnlup approved these changes Apr 2, 2021
View reviewed changes
lib/core/client.js Outdated Show resolved Hide resolved
lib/core/client.js Outdated Show resolved Hide resolved
@ronag

This comment has been minimized.

Sign in to view
@ronag ronag marked this pull request as ready for review April 3, 2021 13:31
dnlup
dnlup approved these changes Apr 3, 2021
View reviewed changes
Copy link
Contributor

@dnlup dnlup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 1c6381e into main Apr 4, 2021
@Uzlopak Uzlopak deleted the fix-headers-timeout branch February 21, 2024 12:39
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@ronag @crysmags
fix: don't headersTimeout while writing request body (nodejs#646)
8d2f828 
* fix: don't headersTimeout while writing request body

Fixes: nodejs#645

* WIP

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@dnlup dnlup dnlup approved these changes

@Ethan-Arrowood Ethan-Arrowood Awaiting requested review from Ethan-Arrowood

Assignees

@ronag ronag

Labels
semver-major Features or fixes that will be included in the next semver major release
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

headersTimeout on uploads
4 participants
@ronag @codecov-io @mcollina @dnlup