Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken link for examples on website #897

Merged
merged 1 commit into from
Jul 23, 2021
Merged

fix: broken link for examples on website #897

merged 1 commit into from
Jul 23, 2021

Conversation

joaopedrocampos
Copy link
Contributor

Fixes the broken examples link for website

Related issue: #868

Broken link (current behaviour)
broken_example

Fixed link
fixed_example

Solution using noCompileLinks that was created from a similar problem. More details on Docsify issue: docsifyjs/docsify#203

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #897 (5e0be36) into main (02a9d13) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          26       26           
  Lines        2132     2132           
=======================================
  Hits         2123     2123           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a9d13...5e0be36. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 88847ee into nodejs:main Jul 23, 2021
@joaopedrocampos joaopedrocampos deleted the fix-examples-broken-link branch July 23, 2021 17:02
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants