document tls.cert.auth #3010
Merged
document tls.cert.auth #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we know that this actually works? |
|
Yes this works. If your TLS handshake doesn't take too much RAM. In my case, I have solid connections to an MQTT broker with full certification + key authentication (which I control). |
marcelstoer
reviewed
Jan 16, 2020
marcelstoer
reviewed
Jan 16, 2020
nwf
reviewed
Jan 17, 2020
nwf
reviewed
Jan 17, 2020
nwf
reviewed
Jan 17, 2020
nwf
reviewed
Jan 17, 2020
nwf
reviewed
Jan 17, 2020
nwf
requested changes
Jan 17, 2020
There was a problem hiding this comment.
Please address comments above. This is a NodeMCU TLS client API, and the documentation must clearly reflect that, and the examples should involve client private keys. Be careful when spelling out who's doing the connecting and proving and verifying and all that.
Hope is gets better ...
nwf
reviewed
Jan 19, 2020
nwf
reviewed
Jan 19, 2020
nwf
reviewed
Jan 19, 2020
|
Hope it is good to go now. If not please let me know. |
marcelstoer
reviewed
Jan 21, 2020
marcelstoer
approved these changes
Jan 21, 2020
|
@marcelstoer found the checkbox. You should now be able to edit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2578.
devbranch rather than formaster.docs/*.<Description of and rationale behind this PR>
Trying to add documentation for tls.cert.auth
Please review and tell me if it is nonsens as I don't really know much about tls.