Removes runtime dep declaration #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run-time dep declarations have been deprecated Homebrew/brew#3948
The node-build dep isn't just recommended, it's required. It was originally marked required so that the node-build dep could be satisfied outside homebrew (via git install, etc). However, this isn't consistent with other nodenv homebrew formula. And it's highly unlikely that one would install node-build outside homebrew, but then use homebrew for the plugins. (Most likely, they would install all of nodenv* the same way, e.g. all homebrew or all via git.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run-time dep declarations have been deprecated
Homebrew/brew#3948