if an event is an error, pass the exception object #3
Conversation
|
Still a little bothered by having a separate upstream PR, esp since we don't know the state of it. I believe the last changes to storage to produce better error messages for already bound zmq ports will be a good enough test to make sure nothings broken between node/npm-zmq and nsolid - make sure you run the storage integration tests w/nsolid to make sure nothings b0rken ... Other than that, LGTM, but not really familiar with the NAN usage in the natives ... |
|
The NAN usage was copied from neighboring code, so it should be ok I'll ping upstream one more time... |
| case "bind_error": | ||
| case "accept_error": | ||
| case "close_error": | ||
| ex = self._zmq.getException(); |
There was a problem hiding this comment.
probably wanna put a break here to prevent fall through if more cases are introduced
|
In general LGTM |
|
Upstream accepted a modified version of this but it's not merged yet. Keeping this open for a few more days to see how that shakes out and when it lands |
|
Upstream fix merged and landed, closing this |
Upstream PR JustinTulloss#578 has not been responded to at this time. I propose to merge this to our fork for now.