Added statistics and webuser colouring. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a button to enable/disable the displaying of statistics. Added colouring for web users. They turn yellow in the user list. The displaying of time required a new js file to be added. This may change in the future, is it worth adding an extra file for something as minor as displaying time in one spot on the page? Altered the css and made additions to support statistics and user coloring. Added an extra js file, starting to break apart the js code, too much in one place. Some code refactoring needed soon. The extra file introduces a fast way to find an array inside another. How fast or fast enough? Still needs testing. The request for statistics is user action triggered. In case it is proven to be to resource intensive another solution can be sought, e.g., on a timer. Slowly starting to get a grip on nuances in between using "" and ''.
Commented out the logging of irc parameters.
chrismatthieu
added a commit
that referenced
this pull request
Mar 31, 2012
Added statistics and webuser colouring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a button to enable/disable the displaying of statistics.
Added colouring for web users. They turn yellow in the user list.
The displaying of time (like gitHub displays it) required a new js file to be added. This may change in the future. Is it worth adding an extra file for something as minor as displaying time in one spot on the page?
Altered the css and made additions to support statistics and user coloring.
Added an extra js file, starting to break apart the js code, too much in one
place. Some code refactoring needed soon. The extra file introduces a fast indexOf() to find the occurence of an array inside another. How fast or fast enough? Or the right choice?! Still needs testing.
The request for statistics is user action triggered. In case it is proven to be to resource intensive another solution can be sought, e.g., on a timer.
Slowly starting to get a grip on nuances in between using "" and ''.