Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to specify custom z-index #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support to specify custom z-index #314

wants to merge 1 commit into from

Conversation

mimo84
Copy link

@mimo84 mimo84 commented Jul 11, 2017

Sometimes the z-index has to be configured if you need to show other elements on top of the popup.

@robneu
Copy link

robneu commented Jul 11, 2017

Couldn't you just change it in CSS?

@marcandre
Copy link
Collaborator

Wow, this is a very well written PR!

Like @robneu I'm also inclined to say that the easiest solution is simply to add a CSS rule. We could make it clearer and official by stating it in the documentation though.

@mimo84
Copy link
Author

mimo84 commented Jul 11, 2017

The issue I have with just modifying the css is that it would work for a simple case but it wouldn't work if you have multiple instances opened and you need to make sure that layers and other elements stack on top of each other correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants