Port to Polymer 1.x #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bergie whats the status? Mostly working or not? Any limitations, or blockers? |
|
@jonnor working fully. Tests passing on both Chrome and PhantomJS |
|
Ok. If we're gonna merge this, then this means bumping major version, since incompatible with old Polymer. Maybe go 1.x to match? |
|
In this case the component migration to 1.x was simply done with https://github.com/PolymerLabs/polyup The only manual tweak was to change the For something like noflo-ui there will likely be CSS changes also needed |
|
@jonnor yes, major bump sounds reasonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs noflo/noflo-ui#537