Allow getting the buffer handle and make Buffer copy
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noib3 Is this okay? |
@oberblastmeister sorry for keeping it open so long, I'll make sure to review this this weekend. |
noib3
requested changes
Jan 29, 2023
| @@ -88,6 +88,10 @@ impl Pushable for Buffer { | |||
| } | |||
|
|
|||
| impl Buffer { | |||
| pub fn handle(&self) -> BufHandle { | |||
There was a problem hiding this comment.
It's missing a doc comment explaining what it returns.
| @@ -27,7 +27,7 @@ use crate::LUA_INTERNAL_CALL; | |||
| use crate::{Error, Result}; | |||
|
|
|||
| /// A wrapper around a Neovim buffer handle. | |||
| #[derive(Clone, Eq, PartialEq, Hash, Serialize, Deserialize)] | |||
| #[derive(Copy, Clone, Eq, PartialEq, Hash, Serialize, Deserialize)] | |||
There was a problem hiding this comment.
I'm not against making the handle wrapper types (i.e. Buffer, Window and TabPage) Copy (in fact at one point they were), but I'd change them all in the same commit.
noib3
force-pushed
the
master
branch
3 times, most recently
from
0278204
to
6f23cf3
Compare
noib3
force-pushed
the
master
branch
2 times, most recently
from
9e63751
to
3f75ed9
Compare
noib3
force-pushed
the
main
branch
3 times, most recently
from
e70b241
to
6124b57
Compare
noib3
force-pushed
the
main
branch
2 times, most recently
from
a1882fd
to
c1a89ca
Compare
|
Closed by #176, which added a Neither of those is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the internal handle is useful when
nxim_oxihasn't made bindings to something yet. I also don't see whyBuffershouldn't beCopy, as it's just an integer. I also don't see how the internals ofBuffercould be changed to something!Copyin the future. I think the other types likeWindowshould be madeCopytoo.