Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow getting the buffer handle and make Buffer copy #80

Closed
wants to merge 2 commits into from
Closed

Allow getting the buffer handle and make Buffer copy #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db90bac
get internal handle
oberblastmeister Oct 19, 2022
3e327ab
make Buffer copy
oberblastmeister Oct 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/nvim-api/src/buffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ use crate::LUA_INTERNAL_CALL;
use crate::{Error, Result};

/// A wrapper around a Neovim buffer handle.
#[derive(Clone, Eq, PartialEq, Hash, Serialize, Deserialize)]
#[derive(Copy, Clone, Eq, PartialEq, Hash, Serialize, Deserialize)]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against making the handle wrapper types (i.e. Buffer, Window and TabPage) Copy (in fact at one point they were), but I'd change them all in the same commit.

pub struct Buffer(pub(crate) BufHandle);

impl fmt::Debug for Buffer {
Expand Down Expand Up @@ -88,6 +88,10 @@ impl Pushable for Buffer {
}

impl Buffer {
pub fn handle(&self) -> BufHandle {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing a doc comment explaining what it returns.

self.0
}

/// Shorthand for [`get_current_buf`](crate::get_current_buf).
#[inline(always)]
pub fn current() -> Self {
Expand Down