Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JS Restify #273

Merged
merged 4 commits into from
Apr 21, 2024
Merged

Support JS Restify #273

merged 4 commits into from
Apr 21, 2024

Conversation

Gby56
Copy link
Contributor

@Gby56 Gby56 commented Apr 12, 2024

Turns out it's pretty much the same thing as Express for now, we can keep it separate if the frameworks are slightly different !
Fixes #272

@hahwul
Copy link
Member

hahwul commented Apr 12, 2024

@ksg97031
Could you switch the destination branch from noir:main to noir:dev when you have a moment? I tried to change it in the GitHub mobile app, but it only shows the default branch.

And I think we should also talk about the default branch later 😉

@Gby56 Gby56 changed the base branch from main to dev April 15, 2024 08:40
@Gby56
Copy link
Contributor Author

Gby56 commented Apr 15, 2024

Done ! @hahwul :) thanks

@ksg97031 ksg97031 added 🔎 detector Issue for Detector 🔬 analyzer Issue for Analyzer 💊 spec Issue for test codes labels Apr 19, 2024
`crystal tool format`
@hahwul
Copy link
Member

hahwul commented Apr 21, 2024

./bin/noir -b ./spec/functional_test/fixtures/js_restify/

# GET /?name=
#   ○ headers: X-API-Key:
# POST /upload
#   ○ cookies: auth=
#   ○ body: {"name":""}
  • Test
crystal spec

# Finished in 17.83 milliseconds
# 822 examples, 0 failures, 0 errors, 0 pending
  • Lint
Inspecting 177 files

.................................................................................................................................................................................

Finished in 396.11 milliseconds
177 inspected, 0 failures

Copy link
Member

@hahwul hahwul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gby56
Hey there!

First off, thanks so much for your patience, especially given my recent break—it really means a lot. The code is clean, well-organized, and just what we need. I'm all set to merge this!

We're aiming to roll this out by next month's release. If anything else pops up or if you have more cool ideas, don’t hesitate to kick off another PR.

Thanks again—you’re awesome!

@hahwul hahwul added this to the NextVersion milestone Apr 21, 2024
@hahwul hahwul merged commit 01d2b02 into noir-cr:dev Apr 21, 2024
5 of 6 checks passed
hahwul added a commit that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔬 analyzer Issue for Analyzer 🔎 detector Issue for Detector 💊 spec Issue for test codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Restify
3 participants