fix: Compute program diffs based off of package name and reset reference report #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
github-merge-queue bot
pushed a commit
to noir-lang/noir
that referenced
this pull request
Apr 10, 2024
# Description ## Problem\* Resolves [<!-- Link to GitHub Issue -->](#4764 (comment)) ## Summary\* This is the noir-gates-diff PR this commit update references: noir-lang/noir-gates-diff#3. ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
5 tasks
|
Ah sorry, I didn't see this PR existed until now. |
|
We reference it here though still https://github.com/noir-lang/noir/blob/19583ba2307afcbe5678b470468175057d1f99f0/.github/workflows/gates_report.yml#L77C40-L77C80 and I was expecting this PR to be the fix. But I guess there is still a bug |
5 tasks
Temp check using same content
vezenovm
changed the title
fix: Use actual reference report
github-merge-queue bot
pushed a commit
to noir-lang/noir
that referenced
this pull request
Apr 23, 2024
# Description ## Problem\* Resolves <!-- Link to GitHub Issue --> Opened this PR to test noir-lang/noir-gates-diff#3 after seeing this #4848 (comment) ## Summary\* The noir-gates-diff report became malformed on master as "main" was used as the program name for each program in `execution_success`. This PR references the last commit in this PR noir-lang/noir-gates-diff#3. That PR changes to using the correct name for each program in `execution_success` but also resets the report on `master` by comparing against a harcoded reference. That is why it is expected to see a massive gate diff report on this PR. The follow-up will revert the changes to accurately check against the reference. ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
* main: chore: fix linting chore: add CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current gate diff checks has a bug where it indexes the first program rather than the first circuit in every program. I switched the
computeProgramDiffsmethod to find common report names based off of the package name now and aProgramReport.