Cannot resolve static struct methods in global declarations

[sirasistant]

Aim

I was trying to create a global struct instance with a property computed by a static method of another struct. A boiled down version of this would be:

struct Foo {
  a: Field,
}

struct Bar {}

impl Bar {
  fn get_a() -> Field {
    1
  }
}

global foo = Foo {
  a: Bar::get_a(),
};


fn main() -> pub Field {
  foo.a
}

Expected Behavior

It should compile without issues, given that the following code does work and is functionally equivalent:

struct Foo {
  a: Field,
}

fn get_a() -> Field {
  1
}

global foo = Foo {
  a: get_a(),
};


fn main() -> pub Field {
  foo.a
}

Bug

Seems like a resolution issue (maybe static struct methods are not globals?):

error: Could not resolve 'get_a' in path
   ┌─ /mnt/user-data/alvaro/constructor/src/main.nr:99:11
   │
99 │   a: Bar::get_a(),
   │           -----

error: aborting due to 1 previous errors
Error: Failed to compile circuit

Location:
    crates/nargo_cli/src/cli/mod.rs:70:5

To Reproduce

1. Compile the above code

Installation Method

Compiled from source

Nargo Version

nargo 0.6.0 (git version hash: 8778a1d, is dirty: false)

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

[kevaundray]

@jfecher is this still an issue?

[jfecher]

@kevaundray yes, name resolution still does not check if a module name is actually a typename

[kevaundray]

@f01dab1e assigning this issue to you!

[ghost]

any hints?

[jfecher]

@f01dab1e I think this may have to do with resolution order of globals. Since globals are currently resolved before structs, I think Bar::get_a may not be registered when the global is being checked. I should make a tracker issue since there are a few other issues caused by this.

[ghost]

if I change the resolution order, it solves the problem above, but creates a new one:

error: Expected type [Field; 0], found type [Field; 5]
   ┌─ noir/crates/nargo_cli/tests/test_data/global_consts/src/main.nr:16:24
   │
16 │      let test_struct = Dummy { x: d, y: c };
   │                        --------------------

error: Expected type [Field; 0], found type [Field; 3]
   ┌─ noir/crates/nargo_cli/tests/test_data/global_consts/src/main.nr:16:24
   │
16 │      let test_struct = Dummy { x: d, y: c };
   │                        --------------------

Error: 
   0: Aborting due to 2 previous errors

[jfecher]

@f01dab1e It looks like your current error is related to globals not being known when those types are resolved, so the array types using globals default to a size of 0. I'm not sure what the desired solution to this ordering problem is - if their is a proper order or if we need a larger solution like creating a dependency tree for the program and using that to solve ordering issues. There are a few other open issues that would need a dependency tree as well.

[TomAFrench]

@jfecher I think that we added new dependency resolution logic to the compiler which closes this issue. Is this correct?

[jfecher]

@TomAFrench no, this is still an issue. The dependency graph verifies we don't have cyclic dependencies but does not actually change resolution order.