Support module attributes #5495
Assignees
Labels
enhancement
New feature or request
Comments
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 12, 2024
# Description ## Problem\* Resolves #5477 ## Summary\* Adds: - The ability to run `comptime` attribute functions on traits & functions in the program - The `TraitDefinition` type - The `FunctionDefinition` type - The `Module` type - the only one of the new types which you still can't run attributes on. See: #5495. Running these on modules is a bit more difficult since modules don't have an entry in `CollectedItems` to run them on. So I'm delaying this for a later PR. ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [x] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 4, 2024
# Description ## Problem Resolves #5495 ## Summary Pending: - [ ] Decide whether to keep attributes as String or SecondaryAttribute in ModuleData - [ ] Parsing of module attributes is not ideal (it errors on non-secondary attributes, but I think not all secondary attributes are valid for modules... but maybe it's fine because struct attributes work the same way) ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
We currently support running comptime attribute functions when a attribute is placed on a struct, trait, or function.
Happy Case
We should support module-level attributes as well as attributes that apply to submodule declarations, e.g:
Project Impact
None
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: