Address few more codacity issues

Signed-off-by: Gautam Venkataramanan <gautam.chennai@gmail.com>

README.md

@@ -11,4 +11,3 @@
 [Prometheus integration](docs/prometheus.md)
 
 [Configuring and using drop logs](docs/drop_logs.md)
-

agent-ovs/lib/logging.cpp

@@ -43,7 +43,7 @@ class OStreamLogSink : public LogSink {
      * Constructor that accepts the output stream to write logs to.
      * @param outStream The stream to send messages to.
      */
-    OStreamLogSink(std::ostream& outStream) : out(&outStream) {
+    explicit OStreamLogSink(std::ostream& outStream) : out(&outStream) {
         static const boost::posix_time::time_facet facet;
         out->imbue(std::locale(out->getloc(), &facet));
     }
@@ -53,7 +53,7 @@ class OStreamLogSink : public LogSink {
      * appended.
      * @param fileName The filename to send log messages to.
      */
-    OStreamLogSink(const std::string& fileName) :
+    explicit OStreamLogSink(const std::string& fileName) :
         fileStream(fileName.c_str(), std::ios_base::out | std::ios_base::app) {
         if (!fileStream.good()) {
             out = &std::cout;
@@ -105,7 +105,7 @@ const char * OStreamLogSink::LEVEL_STR_FATAL = "fatal";
  */
 class SyslogLogSink : public LogSink {
 public:
-    SyslogLogSink(const std::string& name) : syslog_name(name) {
+    explicit SyslogLogSink(const std::string& name) : syslog_name(name) {
         openlog(syslog_name.c_str(), LOG_CONS | LOG_PID, LOG_DAEMON);
     }
     ~SyslogLogSink() {

agent-ovs/ovs/PolicyStatsManager.cpp

@@ -645,7 +645,7 @@ generatePolicyStatsObjects(PolicyCounterMap_t *newCountersMap1,
     if (!newCountersMap1->size() && newCountersMap2) {
         for (PolicyCounterMap_t:: iterator itr = newCountersMap2->begin();
              itr != newCountersMap2->end();
-             itr++) {
+             ++itr) {
             const PolicyFlowMatchKey_t& flowKey = itr->first;
             FlowStats_t&  outCounters = itr->second;
             FlowStats_t   inCounters;

agent-ovs/ovs/integration-test/flowmod_test.cpp

@@ -31,7 +31,7 @@ using namespace opflexagent;
 
 class BlockingFlowReader {
 public:
-    BlockingFlowReader(SwitchConnection *c) {
+    explicit BlockingFlowReader(SwitchConnection *c) {
         conn = c;
         reader.installListenersForConnection(conn);
         cb = boost::bind(&BlockingFlowReader::gotFlow, this, _1, _2);

libopflex/comms/include/yajr/rpc/internal/json_stream_wrappers.hpp

@@ -26,7 +26,7 @@ class IStreamWrapper {
   public:
     typedef char Ch;
 
-    IStreamWrapper(std::istream& is)
+    explicit IStreamWrapper(std::istream& is)
         : is_(is)
         {}
 

libopflex/include/opflex/yajr/rpc/rpc.hpp

@@ -39,7 +39,7 @@ class GeneratorFromValue {
      * Generate JSON from value
      * @param v rapidjson value
      */
-    GeneratorFromValue(rapidjson::Value const & v) : v_(v) {}
+    explicit GeneratorFromValue(rapidjson::Value const & v) : v_(v) {}
 
     /** () operator */
     virtual bool operator()(yajr::rpc::SendHandler& h) {
@@ -139,7 +139,7 @@ class RemoteIdentifier : virtual public Identifier {
      * Construct a remote identitier
      * @param id JSON ID
      */
-    RemoteIdentifier(rapidjson::Value const & id) : id_(id) {}
+    explicit RemoteIdentifier(rapidjson::Value const & id) : id_(id) {}
 
     /**
      * Emit the identifier

libopflex/include/opflex/yajr/transport/engine.hpp

@@ -152,7 +152,7 @@ class TransportEngine : public Transport {
     /**
      * Construct a transport engine
      */
-    TransportEngine(E *);
+    explicit TransportEngine(E *);
     ~TransportEngine();
 };
 

libopflex/modb/URIBuilder.cpp

@@ -36,7 +36,7 @@ class URIBuilder::URIBuilderImpl {
         uri_stream << '/';
     }
 
-    URIBuilderImpl(const URI& uri) { 
+    explicit URIBuilderImpl(const URI& uri) {
         uri_stream.fill('0');
         uri_stream << uri.toString();
     }