This repository has been archived by the owner on Jun 21, 2019. It is now read-only.
Add unit tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires restructuring door_loop a bit, so that we can run finite iterations of it. I tried to modify as little as possible though.
|
Ping? Does this look ok to merge? |
|
These additions are great. I made some changes to master to support daemon-ization, which got your branch out-of-sync. Maybe force-push this into your repo, and let's get this merged.
|
Conflicts: baron.py
|
Sorry, got sidelined by some day job stuff. I merged master into my branch, and all the tests pass. Ok to merge? |
|
That works. Let's ship it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion at the 7/2/2013 meeting, it sounds like there will be a flurry of functionality changes to Baron to allow for things like different access policies at different times of day. I added some unit tests to help make sure we don't break any existing functionality as we hack new features, and so that new people to the codebase (such as me) can make changes without access to running it on the actual hardware.
I tried to make as few changes to the existing code as possible, though I had to change the structure of door_loop() a bit to make it testable.