Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes collection #282

Merged
merged 5 commits into from
May 23, 2022
Merged

Minor fixes collection #282

merged 5 commits into from
May 23, 2022

Conversation

ZyanKLee
Copy link
Contributor

No description provided.

Copy link
Collaborator

@TheDukeofErl TheDukeofErl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you're looking for anyone to review this one yet but it looks fine to me. I wasn't aware of EditorConfig, I'll have to look into plugins for it.

@ZyanKLee
Copy link
Contributor Author

It's low-prio right now, so I did not ask for a review. All the more: thanks for reviewing it.

EditorConfig is a great thing. Especially in teams where many people from different backgrounds work with vastly differing IDEs, editors and tools on the same code base. Some plugins are listed on the page - they exist at least for Atom and VSCode, some IDEs even have built-in support iirc.

@ZyanKLee ZyanKLee merged commit efecc53 into master May 23, 2022
@ZyanKLee ZyanKLee deleted the minor-fixes-collection branch May 23, 2022 21:15
@ZyanKLee ZyanKLee added this to the v0.12.0 milestone May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants