Let append_repeated_bytes and append_repeated_string take generic elements #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buckram123
approved these changes
Jan 3, 2024
| } | ||
|
|
||
| #[test] | ||
| fn append_repeated_bytes_works() { | ||
| // echo "id: \"bytess\"; bytess: [\"\", \"a\", \"bcde\"]" | protoc --encode=Collection *.proto | xxd -p -c 9999 | ||
| let data = Anybuf::new() | ||
| .append_string(1, "bytess") | ||
| .append_repeated_bytes(10, &[b"", b"a", b"bcde"]); | ||
| .append_repeated_bytes::<&[u8]>(10, &[b"", b"a", b"bcde"]); |
There was a problem hiding this comment.
String slices could also be converted to bytes
Suggested change
| .append_repeated_bytes::<&[u8]>(10, &[b"", b"a", b"bcde"]); | |
| .append_repeated_bytes(10, &["", "a", "bcde"]); |
webmaster128
commented
Jan 8, 2024
| /// vec![1u8; 10], | ||
| /// vec![2u8; 10], | ||
| /// vec![3u8; 10], | ||
| /// ]; |
There was a problem hiding this comment.
The nice thing about this example is that it also works the same way for Vec<cosmwasm_std::Binary> and Vec<cosmwasm_std::HexBinary>
webmaster128
force-pushed
the
impl-AsRef
branch
from
9ebf6ac
to
5a3814b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #16
Not sure if this is the nicest approach. Lots is new type annotations necessary (at least in test code).