Fix TS batt correction value in "opentime only" -corretion mode #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge to Speeduino master on 2019-11-11
Sync to noisymime/master on 2019-11-12-21-33
Sync to noisymime/master (201911 release)
… selected, currentStatus.batCorrection value remains at 100 and is useless to log in Tunerstudio. Opentime only -correction stuff was in speeduino.ino and whole time correction was in corrections.ino, moved all more logically to same place.
muuris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
201911 firmware introduced battery correction for opentime only. When selected, currentStatus.batCorrection value remains at 100 and is useless to view or log in Tunerstudio.
Code itself is pretty much unchanged. BATTV_COR_MODE_WHOLE -correction was in corrections.ino inside correctionsFuel() but BATTV_COR_MODE_OPENTIME -correction was in speeduino.ino, so moved opentime -correction logically to same place.