New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added poll level cam trigger type for missing tooth decoder. #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If instead of comparing it in every tooth you compare it in Edit: If you use the macro |
It should compare only at toot#1. Not every tooth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This poll level cam decoder is mainly meant to be used with the "half moon" cam trigger wheels have one big tooth that is half cam rotation wide. This is used with hall sensor in many BMW engines at least (m50tu, m52, m52tu, m54 etc.) plus in engines from other manufacturers too and effectively the cam input is high for one engine rotation and low for second engine rotation. So ecu can just poll the cam input at tooth#1 and know the engine phase immediately from the fact that is the cam input high or low. No need to wait for edge trigger and this allows very fast sequential sync.
Example cam trigger wheel:
As for example in this the yellow is the injector pulses and blue 60-2 cam signal. This is with regular one tooth at cam decoder:
This is how much faster sync the poll level decoder gets:
The decoder can be used with other type of cam trigger wheels if those use hall sensor and the section for low and high are wide enough around #1tooth. Adding adjustable tooth for checking the phase would make this more versatile, but I couldn't get that working without too much of a performance hit. But #1tooth to check should work for majority of the cases.
There is pattern for ardustim to test this here: speeduino/Ardu-Stim#3
This also works with closed loop VVT.