Deduplicate ignition scheduler code #686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the decoder and scheduler tests. Both are successful. |
TBAMax
added a commit
to TBAMax/speeduino
that referenced
this pull request
Nov 27, 2021
Combine setIgnitionSchedule functions into a new generic function. This reduces code duplication in this area quite a lot. This is a continuation/alternative from noisymime#686 and noisymime#578. Only taking some(better) parts from the both and keeping changes in the manageable level. Only the code parts that are in the main loop are modified, interrupts are left as is at the moment, because do not want to add extra function calls to the interrupts. And also this would be to probably too much for single PR. It was discovered that ignitionSchedule[i].member calls seem to be slowed than ignitionSchedule->member calls so this uses the latter variant. Also this seems to be the safer option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a direct continuation of #648 and that pull request is used as base. It is also related to #578.
This change more or less only refactors code. The logic changes are that the scheduler callbacks are only set once in initialiseAll and a small optimization into calculateIgnitionAngleWithSpecificEndAngle for rotary.
ignitionSchedule[i].member calls seem to be slowed than ignitionSchedule->member calls. This is why most functions pass a pointer to the array member rather than the number of the ignition channel.
Tested on mega2560. Loops/sec reduced by 0,5% (from Tunerstudio). Size reduced by 1,8% and memory by 0,72% (PlatformIO compile info). I've done some basic testing on the bench and the ignition events appear to happen at the correct time (scope tested).
There are other areas where code can be deduplicated as a continuation of this change.