Don't add additional new line before new. Fixes fsprojects#1049.

nojaf · Aug 28, 2020 · 6b8f3ee · 6b8f3ee
1 parent faf5419
commit 6b8f3ee
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/src/Fantomas.Tests/LetBindingTests.fs b/src/Fantomas.Tests/LetBindingTests.fs
@@ -830,4 +830,32 @@ let notFound () =
 
     new HttpResponseMessage(HttpStatusCode.NotFound,
                             Content = new StringContent(json, System.Text.Encoding.UTF8, "application/json"))
-"""
+"""
+
+[<Test>]
+let ``don't add additional newline before SynExpr.New, 1049`` () =
+    formatSourceString false """
+    let getVersion () =
+        let version =
+            let assembly =
+                typeof<FSharp.Compiler.SourceCodeServices.FSharpChecker>.Assembly
+
+            let version = assembly.GetName().Version
+            sprintf "%i.%i.%i" version.Major version.Minor version.Revision
+
+        new HttpResponseMessage(HttpStatusCode.OK,
+                                Content = new StringContent(version, System.Text.Encoding.UTF8, "application/text"))
+"""  config
+    |> prepend newline
+    |> should equal """
+let getVersion () =
+    let version =
+        let assembly =
+            typeof<FSharp.Compiler.SourceCodeServices.FSharpChecker>.Assembly
+
+        let version = assembly.GetName().Version
+        sprintf "%i.%i.%i" version.Major version.Minor version.Revision
+
+    new HttpResponseMessage(HttpStatusCode.OK,
+                            Content = new StringContent(version, System.Text.Encoding.UTF8, "application/text"))
+"""
diff --git a/src/Fantomas/CodePrinter.fs b/src/Fantomas/CodePrinter.fs
@@ -1658,6 +1658,7 @@ and genExpr astContext synExpr =
             | SynExpr.AnonRecd _ -> sepNlnConsideringTriviaContentBeforeFor SynExpr_AnonRecd e.Range
             | SynExpr.ArrayOrListOfSeqExpr _ -> sepNlnConsideringTriviaContentBeforeFor SynExpr_ArrayOrListOfSeqExpr e.Range
             | SynExpr.LongIdentSet _ -> sepNlnConsideringTriviaContentBeforeFor SynExpr_LongIdentSet e.Range
+            | SynExpr.New _ -> sepNlnConsideringTriviaContentBeforeFor SynExpr_New e.Range
             | _ -> sepNln
 
         atCurrentColumn (genLetOrUseList astContext bs +> ifElseCtx isInSameLine (!- " in ") sepNlnBeforeExpr  +> genExpr astContext e)