Add newline between multiline infix expression in if expression. Fixes …

…fsprojects#1584.
nojaf · Apr 3, 2021 · 90fe9a0 · 90fe9a0
1 parent 227d44a
commit 90fe9a0
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 1 deletion.
diff --git a/src/Fantomas.Tests/IfThenElseTests.fs b/src/Fantomas.Tests/IfThenElseTests.fs
@@ -2085,3 +2085,40 @@ then
 else
     ()
 """
+
+[<Test>]
+let ``multiline infix expression in if expression, 1584`` () =
+    formatSourceString
+        false
+        """
+        if sourceCode.EndsWith("\n")
+               && not
+                  <| formattedSourceCode.EndsWith(Environment.NewLine) then
+                return formattedSourceCode + Environment.NewLine
+            elif
+                not <| sourceCode.EndsWith("\n")
+                && formattedSourceCode.EndsWith(Environment.NewLine)
+            then
+                return formattedSourceCode.TrimEnd('\r', '\n')
+            else
+                return formattedSourceCode
+"""
+        config
+    |> prepend newline
+    |> should
+        equal
+        """
+if
+    sourceCode.EndsWith("\n")
+    && not
+       <| formattedSourceCode.EndsWith(Environment.NewLine)
+then
+    return formattedSourceCode + Environment.NewLine
+elif
+    not <| sourceCode.EndsWith("\n")
+    && formattedSourceCode.EndsWith(Environment.NewLine)
+then
+    return formattedSourceCode.TrimEnd('\r', '\n')
+else
+    return formattedSourceCode
+"""
diff --git a/src/Fantomas/CodePrinter.fs b/src/Fantomas/CodePrinter.fs
@@ -2269,7 +2269,7 @@ and genExpr astContext synExpr ctx =
                             indent
                             +> sepNln
                             +> genAlternativeAppWithParenthesis app astContext
-                            +> sepSpace
+                            +> ifElse (noBreakInfixOps.Contains(s)) sepSpace sepNln
                             +> genInfixOperator s e
                             +> sepSpace
                             +> genExpr astContext e2