Warn on FS1178

Directory.Build.props

@@ -26,7 +26,12 @@ Some common use cases include:
         <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
         <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
         <WarningsAsErrors>FS0025;FS1182</WarningsAsErrors>
-        <WarnOn>1182;3390;$(WarnOn)</WarnOn>
+        <!--
+        FS0025: Incomplete pattern matches on this expression.
+        FS1182	Unused variables
+        FS1178 does not support structural equality
+        -->
+        <WarnOn>1182;3390;1178;$(WarnOn)</WarnOn>
         <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
         <RestoreLockedMode>true</RestoreLockedMode>
         <NoWarn>NU1603</NoWarn>

src/Fantomas.Client/Contracts.fs

@@ -19,6 +19,7 @@ module Methods =
     [<Literal>]
     let Configuration = "fantomas/configuration"
 
+[<NoComparison>]
 type FormatDocumentRequest =
     { SourceCode: string
       FilePath: string
@@ -35,6 +36,7 @@ and FormatCursorPosition =
         new(line: int, column: int) = { Line = line; Column = column }
     end
 
+[<NoComparison>]
 type FormatSelectionRequest =
     {
         SourceCode: string
@@ -63,6 +65,7 @@ and FormatSelectionRange =
               EndColumn = endColumn }
     end
 
+[<NoComparison>]
 type FantomasResponse =
     { Code: int
       FilePath: string

src/Fantomas.Client/Contracts.fsi

@@ -18,6 +18,7 @@ module Methods =
     [<Literal>]
     val Configuration: string = "fantomas/configuration"
 
+[<NoComparison>]
 type FormatDocumentRequest =
     {
         SourceCode: string
@@ -43,6 +44,7 @@ and FormatCursorPosition =
         val Column: int
     end
 
+[<NoComparison>]
 type FormatSelectionRequest =
     {
         SourceCode: string
@@ -69,6 +71,7 @@ and FormatSelectionRange =
         val EndColumn: int
     end
 
+[<NoComparison>]
 type FantomasResponse =
     {
         Code: int

src/Fantomas.Client/LSPFantomasService.fs

@@ -10,6 +10,7 @@ open Fantomas.Client.Contracts
 open Fantomas.Client.LSPFantomasServiceTypes
 open Fantomas.Client.FantomasToolLocator
 
+[<NoComparison>]
 type ServiceState =
     { Daemons: Map<FantomasVersion, RunningFantomasTool>
       FolderToVersion: Map<Folder, FantomasVersion> }
@@ -25,6 +26,7 @@ type GetDaemonError =
     | InCompatibleVersionFound
     | CompatibleVersionIsKnownButNoDaemonIsRunning of version: FantomasVersion
 
+[<NoComparison>]
 type Msg =
     | GetDaemon of folder: Folder * replyChannel: AsyncReplyChannel<Result<JsonRpc, GetDaemonError>>
     | Reset of AsyncReplyChannel<unit>

src/Fantomas.Client/LSPFantomasServiceTypes.fs

@@ -18,7 +18,7 @@ type FantomasResponseCode =
     | CancellationWasRequested = 10
     | DaemonCreationFailed = 11
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoComparison>]
 type FormatSelectionResponse =
     | Formatted of filename: string * formattedContent: string * formattedRange: FormatSelectionRange
     | Error of filename: string * formattingError: string
@@ -38,7 +38,7 @@ type FormatSelectionResponse =
               SelectedRange = None
               Cursor = None }
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoComparison>]
 type FormatDocumentResponse =
     | Formatted of filename: string * formattedContent: string * cursor: FormatCursorPosition option
     | Unchanged of filename: string
@@ -55,6 +55,7 @@ type FantomasToolStartInfo =
     | GlobalTool
     | ToolOnPath of executableFile: FantomasExecutableFile
 
+[<NoComparison>]
 type RunningFantomasTool =
     { Process: Process
       RpcClient: JsonRpc

src/Fantomas.Client/LSPFantomasServiceTypes.fsi

@@ -15,14 +15,14 @@ type FantomasResponseCode =
     | CancellationWasRequested = 10
     | DaemonCreationFailed = 11
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoComparison>]
 type FormatSelectionResponse =
     | Formatted of filename: string * formattedContent: string * formattedRange: FormatSelectionRange
     | Error of filename: string * formattingError: string
 
     member AsFormatResponse: unit -> FantomasResponse
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoComparison>]
 type FormatDocumentResponse =
     | Formatted of filename: string * formattedContent: string * cursor: FormatCursorPosition option
     | Unchanged of filename: string
@@ -41,6 +41,7 @@ type FantomasToolStartInfo =
     | GlobalTool
     | ToolOnPath of executableFile: FantomasExecutableFile
 
+[<NoComparison>]
 type RunningFantomasTool =
     { Process: System.Diagnostics.Process
       RpcClient: StreamJsonRpc.JsonRpc

src/Fantomas.Core/ASTTransformer.fs

@@ -12,6 +12,7 @@ open Fantomas.Core.RangePatterns
 open Fantomas.Core.SyntaxOak
 open Microsoft.FSharp.Core
 
+[<NoComparison>]
 type CreationAide =
     { SourceText: ISourceText option }
 
@@ -595,7 +596,7 @@ let (|ParenMatchLambda|_|) e =
 let mkMatchLambda creationAide mFunction cs m =
     ExprMatchLambdaNode(stn "function" mFunction, List.map (mkSynMatchClause creationAide) cs, m)
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoEquality; NoComparison>]
 type LinkExpr =
     | Identifier of
         // Could be SynExpr.LongIdent or SynExpr.TypeApp(LongIdent)

src/Fantomas.Core/CodeFormatterTypes.fs

@@ -2,6 +2,7 @@
 
 open Fantomas.FCS.Text
 
+[<NoComparison>]
 type FormatResult =
     {
         /// Formatted code

src/Fantomas.Core/Context.fs

@@ -183,7 +183,7 @@ module WriterEvents =
             | WriteLineBecauseOfTrivia -> true
             | _ -> false)
 
-[<System.Diagnostics.DebuggerDisplay("\"{Dump()}\"")>]
+[<System.Diagnostics.DebuggerDisplay("\"{Dump()}\""); NoComparison>]
 type Context =
     { Config: FormatConfig
       WriterModel: WriterModel
@@ -961,13 +961,15 @@ let autoIndentAndNlnIfExpressionExceedsPageWidthUnlessStroustrup f (e: Expr) (ct
     else
         autoIndentAndNlnIfExpressionExceedsPageWidth (f e) ctx
 
+[<NoComparison; NoEquality>]
 type ColMultilineItem =
     | ColMultilineItem of
         // current expression
         expr: (Context -> Context) *
         // sepNln of current item
         sepNln: (Context -> Context)
 
+[<NoComparison>]
 type ColMultilineItemsState =
     { LastBlockMultiline: bool
       Context: Context }

src/Fantomas.Core/Context.fsi

@@ -51,7 +51,7 @@ type WriterModel =
 
     member IsDummy: bool
 
-[<System.Diagnostics.DebuggerDisplay("\"{Dump()}\"")>]
+[<System.Diagnostics.DebuggerDisplay("\"{Dump()}\""); NoComparison>]
 type Context =
     { Config: FormatConfig
       WriterModel: WriterModel
@@ -264,6 +264,7 @@ val autoIndentAndNlnTypeUnlessStroustrup: f: (Type -> Context -> Context) -> t:
 val autoIndentAndNlnIfExpressionExceedsPageWidthUnlessStroustrup:
     f: (Expr -> Context -> Context) -> e: Expr -> ctx: Context -> Context
 
+[<NoComparison; NoEqualityAttribute>]
 type ColMultilineItem = ColMultilineItem of expr: (Context -> Context) * sepNln: (Context -> Context)
 
 /// This helper function takes a list of expressions and ranges.

src/Fantomas.Core/MultipleDefineCombinations.fs

@@ -1,7 +1,6 @@
 module internal Fantomas.Core.MultipleDefineCombinations
 
 open System
-open System.Linq
 open System.Text
 open System.Text.RegularExpressions
 open Microsoft.FSharp.Core.CompilerServices
@@ -107,12 +106,14 @@ type CodeFragment =
             // You should never enter the case where you need to compare a hash line with something other than a hash line.
             | x, other -> failwith $"Cannot compare %A{x} with %A{other}"
 
+[<NoComparison>]
 type FormatResultForDefines =
     { Result: FormatResult
       Defines: DefineCombination
       Fragments: CodeFragment list }
 
 /// Accumulator type used when building up the fragments.
+[<NoComparison>]
 type SplitHashState =
     { CurrentBuilder: StringBuilder
       LinesCollected: int
@@ -129,6 +130,7 @@ and [<RequireQualifiedAccess>] LastLineInfo =
     | Content
 
 /// Accumulator type used when folding over the selected CodeFragments.
+[<NoComparison>]
 type FragmentWeaverState =
     { LastLine: int
       Cursors: Map<DefineCombination, pos>

src/Fantomas.Core/Selection.fs

@@ -71,7 +71,7 @@ let findNode (selection: range) (node: Node) : Node option =
 
     if isExactSelection then Some node else None
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoComparison>]
 type TreeForSelection =
     /// Format this tree and return the entire result.
     | Standalone of Oak

src/Fantomas.Core/SyntaxOak.fs

@@ -95,7 +95,7 @@ let combineRanges (ranges: range seq) =
     else
         Seq.reduce Range.unionRanges ranges
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoComparison>]
 type IdentifierOrDot =
     | Ident of SingleTextNode
     | KnownDot of SingleTextNode
@@ -1199,7 +1199,7 @@ type LinkSingleAppUnit(functionName: Expr, unit: UnitNode, range) =
     member val FunctionName = functionName
     member val Unit = unit
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoComparison; NoEquality>]
 type ChainLink =
     | Identifier of Expr
     | Dot of SingleTextNode
@@ -1417,7 +1417,7 @@ type ElseIfNode(mElse: range, mIf: range, condition: Node, range) as elseIfNode
         member _.AddCursor _ = ()
         member _.TryGetCursor = None
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoComparison>]
 type IfKeywordNode =
     | SingleWord of SingleTextNode
     | ElseIf of ElseIfNode
@@ -1553,6 +1553,7 @@ type StaticOptimizationConstraintWhenTyparTyconEqualsTyconNode(typar: SingleText
     member val TypeParameter = typar
     member val Type = t
 
+[<NoComparison>]
 type StaticOptimizationConstraint =
     | WhenTyparTyconEqualsTycon of StaticOptimizationConstraintWhenTyparTyconEqualsTyconNode
     | WhenTyparIsStruct of SingleTextNode

src/Fantomas/Format.fs

@@ -6,7 +6,7 @@ open Fantomas.Core
 
 type ProfileInfo = { LineCount: int; TimeTaken: TimeSpan }
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoComparison>]
 type FormatResult =
     | Formatted of filename: string * formattedContent: string * profileInfo: ProfileInfo option
     | Unchanged of filename: string * profileInfo: ProfileInfo option
@@ -32,6 +32,7 @@ type FormatParams =
           Profile = profile
           File = file }
 
+[<NoComparison>]
 type CheckResult =
     { Errors: (string * exn) list
       Formatted: string list }

src/Fantomas/Format.fsi

@@ -5,7 +5,7 @@ open Fantomas.Core
 
 type ProfileInfo = { LineCount: int; TimeTaken: TimeSpan }
 
-[<RequireQualifiedAccess>]
+[<RequireQualifiedAccess; NoComparison>]
 type FormatResult =
     | Formatted of filename: string * formattedContent: string * profileInfo: ProfileInfo option
     | Unchanged of filename: string * profileInfo: ProfileInfo option
@@ -22,6 +22,7 @@ type FormatParams =
     static member Create: bool * bool * string -> FormatParams
     static member Create: FormatConfig * bool * bool * string -> FormatParams
 
+[<NoComparison>]
 type CheckResult =
     { Errors: (string * exn) list
       Formatted: string list }

src/Fantomas/IgnoreFile.fs

@@ -19,6 +19,7 @@ type AbsoluteFilePath =
 /// of the ignore-file.
 type IsPathIgnored = AbsoluteFilePath -> bool
 
+[<NoComparison; NoEquality>]
 type IgnoreFile =
     { Location: IFileInfo
       IsIgnored: IsPathIgnored }

src/Fantomas/IgnoreFile.fsi

@@ -13,6 +13,7 @@ type AbsoluteFilePath =
 /// of the ignore-file.
 type IsPathIgnored = AbsoluteFilePath -> bool
 
+[<NoComparison; NoEquality>]
 type IgnoreFile =
     { Location: IFileInfo
       IsIgnored: IsPathIgnored }