Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bit 48 on items #10

Open
dschu012 opened this issue May 3, 2020 · 1 comment
Open

bit 48 on items #10

dschu012 opened this issue May 3, 2020 · 1 comment

Comments

@dschu012
Copy link
Contributor

dschu012 commented May 3, 2020

https://github.com/nokka/d2s/blob/master/d2s.go#L800

at offset 48 is an 8 bit version number having one of the following values.

0 = pre-1.08; 1 = 1.08/1.09 normal; 2 = 1.10 normal; 100 = 1.08/1.09 expansion; 101 = 1.10 expansion

credits to https://github.com/nickshanks/Alkor/blob/master/Source/Item.m#L103 for the info. it is important if u want to be able to rebuild the d2s from your json output. if the version is wrong you can get weird stuff like

image

where it give's + to pally skills instead of sorc.

@nokka
Copy link
Owner

nokka commented May 4, 2020

That's interesting, thanks so much! I'll have a look, I never figured out what those bits where for.

dschu012 added a commit to dschu012/d2s-1 that referenced this issue Sep 17, 2020
* add item version
* make prefix/suffixes a fixed length array
* add simple unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants