Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make MagicalNameIDs a fixed length array #11

Open
dschu012 opened this issue Jun 25, 2020 · 0 comments
Open

make MagicalNameIDs a fixed length array #11

dschu012 opened this issue Jun 25, 2020 · 0 comments

Comments

@dschu012
Copy link
Contributor

item.MagicalNameIDs should be a fixed length array of 6. if you have a rare w/ 3 prefixes and 1 suffix you'd have an array of size 4 similar to

[143, 436, 583, 370]

as it is right now there is no way to distinguish between what is a prefix and what is a suffix. ideally you'd want something along the lines of.

[143, 436, 583, null, 370, null]

https://github.com/nokka/d2s/blob/master/d2s.go#L954
dschu012 added a commit to dschu012/d2s-1 that referenced this issue Sep 17, 2020
@dschu012
address issue nokka#10 and nokka#11.
6d182d5 
* add item version
* make prefix/suffixes a fixed length array
* add simple unit test
@dschu012 dschu012 mentioned this issue Sep 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dschu012