New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAN Resubmission #15
Conversation
…was compiling on my system
…hing to upstream (nolanlab/Rclusterpp)
Dear @rbruggner, could you have a look to the proposed PR? Best. |
I'll take a look at this later this week. |
@bnaras If you don't have time to take a look, i can probably work on in the next week or two - lmk! |
I merged this, but still several warnings on deprecated headers... The pragma warnings are harmless, but the deprecated warnings will not pass CRAN. @rbruggner can you take a look at this, please? See attached. |
Yes - I can take a look this week. |
Quick update - I wasn't able to recreate the pragma warnings in linux. Will get access to a mac os x env for testing soon... |
@rbruggner @bnaras I had offered to resubmit to CRAN. So I don't repeat any work already done, is that something you have already done? Or should I go ahead and resubmit Rob's latest version (which suppresses the deprecated warnings)? |
It won't pass CRAN checks because of the warnings and so it cannot be submitted as it stands now.
|
@bnaras It seems like the only real note is the following. Would that lead to rejection?
|
Yes, unfortunately. It should be relatively easy to fix the root cause, I'd think. @rbruggner ? |
I have relatively little CRAN xp so hard for me to know what passes the bar or not. My brief readings on the warnings lead me to believe that the RccpEigen package was most of root cause, and the RcppEigen maintainer (Dirk, super experienced) just recommended to suppress the warnings, so that's what I went for. Warnings suppressions were added in 6a17290 so at this point, maybe we just submit and see if we get rejected? @mlinderm I have not tried to submit to cran yet. Up to y'all! |
@rbruggner I see. I didn't examine the warning carefully. Some warnings from Eigen are expected and my packages generate those too. Why don't you try submitting to CRAN and see what happens. In the submission, be sure to note in the comment field that the notes and warnings are coming from RcppEigen and that you're following the recommendations of the the RcppEigen author Dirk. |
Hello,
I was wondering if the maintainer would be willing to try and resubmit this package to CRAN. A colleague and I would like to submit a package to CRAN that also depends on this package. I had forked this repository to my own Github and made a few edits. These edits include:
inherits(x, "dist")
instead ofclass(x) == 'dist'
to avoid warning messagesWith these changes I was able to build this with the github actions which had built for all OS except for MacOS. The issue with Mac OS seems to be with the use of
pointer_to_binary_function
and functions like this that have been deprecated in C++11.I believe this will still be permissible for CRAN. Please let me know if this is something you are willing to do.