Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Node.js Performance Timing API #17

Closed
ehmicky opened this issue May 27, 2019 · 3 comments · Fixed by #38
Closed

Add support for Node.js Performance Timing API #17

ehmicky opened this issue May 27, 2019 · 3 comments · Fixed by #38
Labels
enhancement

Comments

@ehmicky
Copy link

ehmicky commented May 27, 2019

Node.js 8.5.0 includes performance.measure(), performance.mark(), performance.clearMarks() and performanceObserverEntryList.getEntries().

Adding support would be nice. Thanks for this library!
@nolanlawson nolanlawson mentioned this issue Feb 15, 2022
Closed
@nolanlawson
Copy link
Owner

Node 16 now exposes a global performance object, so this is automatically fixed in Node 16.

See discussion in #29

@nolanlawson nolanlawson reopened this Feb 15, 2022
@nolanlawson
Copy link
Owner

In #31 we removed the built-in Node performance API in v16, so this issue should be reopened. We need to figure out the perf degradation issue in Node before switching back, though.

@nolanlawson nolanlawson mentioned this issue Feb 16, 2022
Closed
@nolanlawson
Copy link
Owner

Currently our tests fail when using Node's built-in performance API. I filed a bug: nodejs/node#42024

nolanlawson added a commit that referenced this issue Jul 4, 2022
@nolanlawson
fix: use native performance object in Node 18
05bfb6f 
Fixes #17
@nolanlawson nolanlawson mentioned this issue Jul 4, 2022
Merged
nolanlawson added a commit that referenced this issue Jul 4, 2022
@nolanlawson
fix: use native performance object in Node 18 (#38)
4933c46 
Fixes #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@nolanlawson @ehmicky