Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating build scripts #74

Open
sidmani opened this issue Jun 4, 2018 · 3 comments
Open

Updating build scripts #74

sidmani opened this issue Jun 4, 2018 · 3 comments
Assignees

Comments

@sidmani
Copy link

sidmani commented Jun 4, 2018

New build scripts are necessary for v2 of PokeAPI, which is mostly incompatible with v1.
I'm thinking about rewriting the scripts to pull straight from the CSVs here. That would remove the dependency on PokeAPI and allow us to clean up the project structure by having all the source data in the same place, instead of storing some data files in src/js/shared/data.

The only foreseeable issue is that the scripts would become considerably more complex because they would have to index everything and then construct the Pokemon objects, instead of getting ready-made objects from the API.

I'll get started on this sometime next week, after I finish final exams.

@sidmani sidmani self-assigned this Jun 4, 2018
@nolanlawson
Copy link
Owner

Sounds reasonable to me; whatever you find easiest. Perhaps the scripts could also just operate off of the public PokeAPI to avoid having to build a local copy. I built the local copy to avoid hitting the main service and potentially overtaxing them or getting rate-limited.

@sidmani
Copy link
Author

sidmani commented Jun 18, 2018

Developing this on the generate-from-csv branch.

@sidmani
Copy link
Author

sidmani commented Jun 25, 2018

See #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants