Substitute K8s API errors with our own classes #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 6c16c4a into 8023ea4 - view on LGTM.com new alerts:
|
`aiohttp` is currently the underlying client library, and it raises its response errors. To enrich them with K8s's own explanations, the errors were extended by inheriting from the client library in #558. But anyway, this violates the principle that the API/HTTP client library is isolated to `kopf.clients`, and no single piece of it leaks outside to other packages (for replaceability). Instead, introduce our own hierarchy of exceptions for K8s API errors, which are completely independent of the underlying library. The only connection to the original exceptions will be error chaining (`raise ... from ...`). This allows us to analyse the API errors in other packages without coupling to the underlying library, while keeps the goal of readable stack traces and error explanations in the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aiohttpis currently the underlying client library, and it raises its response errors. To enrich them with K8s's own explanations, the errors were extended by inheriting from the client library in #558. But anyway, this violates the principle that the API/HTTP client library is isolated tokopf.clients, and no single piece of it leaks outside to other packages (for replaceability).Instead, introduce our own hierarchy of exceptions for K8s API errors, which are completely independent of the underlying library. The only connection to the original exceptions will be error chaining (
raise ... from ...).This allows us to analyse the API errors in other packages without coupling to the underlying library, while keeps the goal of readable stack traces and error explanations in the logs.