Expose typings for the library users #704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These changes expose the type hints for the library users and fix the callbacks interfaces issue. The exposing is described in the PEP561.
Description
If there is no
py.typed
file in the library root,mypy
doesn't discover the type hints from the sources.So for the following command:
fails with message:
After the PR will be merged the command above should pass successfully:
The change does not affect the end-users and there are no breaking changes.
Type of changes
Checklist
CONTRIBUTORS.txt