Resolve circular imports bound to HandlerId #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chain of dependencies this time was (introduced in e89ac21): * `callbacks` imported `configuration` for the "settings" kwarg. * `configuration` imported `storage.progress` for its persistence settings. * `storage.progress` imported `handlers` for only `HandlerId`. * `handlers` imported `callbacks` for handlers' function types. The chain is broken at the `progress`->`handlers` dependency: it is now `progress`->`ids`. This was a frequent problem before, so `HandlerId` deserves its dedicated moduled until all modules are rebalanced (later). Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
|
This pull request fixes 31 alerts when merging 8fb507c into db2c6cd - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chain of dependencies this time was (introduced in e89ac21, #708's "examples"):
callbacksimportedconfigurationfor the "settings" kwarg.configurationimportedstorage.progressfor its persistence settings.storage.progressimportedhandlersfor onlyHandlerId.handlersimportedcallbacksfor handlers' function types.The chain is broken at the
progress->handlersdependency: it is nowprogress->ids.This was a frequent problem before, so
HandlerIddeserves its dedicated moduled until all modules are rebalanced (later).