-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: mv data processing to vite side #269
Merged
nekomeowww
merged 9 commits into
nolebase:main
from
northword:dev/git-changelog-refactor-data
Jul 21, 2024
Merged
refactor!: mv data processing to vite side #269
nekomeowww
merged 9 commits into
nolebase:main
from
northword:dev/git-changelog-refactor-data
Jul 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Successfully deployed to Netlify
|
Possibly related #45 |
nekomeowww
approved these changes
Jul 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
difficulty/hard
Hard to deal with / implement against
enhancement
New feature or request
pkg/git-changelog
Related to @nolebase/vitepress-plugin-git-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #45
closes: #223
closes: #232
Working in progress
This PR modifies the structure of the data generated on the Vite side to avoid useless data entering the build results.
In addition, moving some of the data processing from the client side to the vite side (mainly the mapAuthors part) should make the logic clearer after the modification:
By the way, since the data processing is all done on the Vite side, it may be more friendly to some advanced users who need to use custom Vue components(?).
Using the build results from this repository as a benchmark, comparing the size of theme.hash.js (since all Git Logs currently go into theme.hash.js): before the PR, the file is 1.41M, after the PR it's 0.99M.
BREAKING CHANGEs:
mapAuthors
is now configured in the vite plugin instead of the Vue plugin.