You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 20, 2021. It is now read-only.
ipa distribute:hockeyapp now (awesomely) does not hard-block shenzhen from executing without an IPA file (version 0.4.0) - however, the rest of the code still expects the file to exist.
Issue 1: If the IPA file exists in the directory, but is not specified in the command-line parameters, the IPA is automatically detected and submitted.
Issue 2: If the IPA file does NOT exist, parts of the code still attempt to use it, and fail. For example, hockeyapp.rb:22 specifically looks for this file, and seems to cause an issue at a lower level in the multi-part code if you remove the IPA from the directory and then run ipa distribute:hockeyapp.
Suggested Fix: I imagine many users prefer the IPA to auto-detect and auto-upload, so I I suggest to leave the auto-detection of IPA and dSYM files in the build.
Instead, perhaps there should be a --doNotUploadIPA command-line flag that can be set (and then create conditions in the Ruby code to prevent the file from being uploaded throughout the code if doNotUploadIPA == yes). This would allow all users their desired functionality (and simplify the command-line for users in my case, since the requisite files would be auto-detected, but only the dSYM would be uploaded).
Also, apologies, I'm totally illiterate in both the gemfile or the Ruby worlds - otherwise I would implement this fix & just pull request back.
Thank you!
The text was updated successfully, but these errors were encountered:
ipa distribute:hockeyapp
now (awesomely) does not hard-block shenzhen from executing without an IPA file (version 0.4.0) - however, the rest of the code still expects the file to exist.Issue 1: If the IPA file exists in the directory, but is not specified in the command-line parameters, the IPA is automatically detected and submitted.
Issue 2: If the IPA file does NOT exist, parts of the code still attempt to use it, and fail. For example,
hockeyapp.rb:22
specifically looks for this file, and seems to cause an issue at a lower level in the multi-part code if you remove the IPA from the directory and then runipa distribute:hockeyapp
.Suggested Fix: I imagine many users prefer the IPA to auto-detect and auto-upload, so I I suggest to leave the auto-detection of IPA and dSYM files in the build.
Instead, perhaps there should be a
--doNotUploadIPA
command-line flag that can be set (and then create conditions in the Ruby code to prevent the file from being uploaded throughout the code ifdoNotUploadIPA == yes
). This would allow all users their desired functionality (and simplify the command-line for users in my case, since the requisite files would be auto-detected, but only the dSYM would be uploaded).Also, apologies, I'm totally illiterate in both the gemfile or the Ruby worlds - otherwise I would implement this fix & just pull request back.
Thank you!
The text was updated successfully, but these errors were encountered: