Skip to content
This repository has been archived by the owner on Jun 20, 2021. It is now read-only.

IPA file still required in ipa distribute:hockeyapp (and uploads if present) #44

Closed
toblerpwn opened this issue May 30, 2013 · 1 comment

Comments

@toblerpwn
Copy link

ipa distribute:hockeyapp now (awesomely) does not hard-block shenzhen from executing without an IPA file (version 0.4.0) - however, the rest of the code still expects the file to exist.

Issue 1: If the IPA file exists in the directory, but is not specified in the command-line parameters, the IPA is automatically detected and submitted.

Issue 2: If the IPA file does NOT exist, parts of the code still attempt to use it, and fail. For example, hockeyapp.rb:22 specifically looks for this file, and seems to cause an issue at a lower level in the multi-part code if you remove the IPA from the directory and then run ipa distribute:hockeyapp.

Suggested Fix: I imagine many users prefer the IPA to auto-detect and auto-upload, so I I suggest to leave the auto-detection of IPA and dSYM files in the build.

Instead, perhaps there should be a --doNotUploadIPA command-line flag that can be set (and then create conditions in the Ruby code to prevent the file from being uploaded throughout the code if doNotUploadIPA == yes). This would allow all users their desired functionality (and simplify the command-line for users in my case, since the requisite files would be auto-detected, but only the dSYM would be uploaded).

Also, apologies, I'm totally illiterate in both the gemfile or the Ruby worlds - otherwise I would implement this fix & just pull request back.

Thank you!

mattt added a commit that referenced this issue Oct 4, 2013
…pa if present in current directory, one can specify a non-existent file.
@mattt
Copy link
Contributor

mattt commented Oct 4, 2013

Hey @toblerpwn, sorry for the late response on all of this.

Everything works for Issue 2 with 81c89ca, and dcfc0f8 is a valid workaround (simply specify a blank or non-existent IPA file).

I hope that works for you! I'll be cutting a new release of this soon, now that I finally have a chance to do some maintenance on this project.

@mattt mattt closed this as completed Oct 4, 2013
mattt added a commit that referenced this issue Nov 13, 2013
…pa if present in current directory, one can specify a non-existent file.
mbaltaks pushed a commit to mbaltaks/shenzhen that referenced this issue Jun 2, 2015
…o skip .ipa if present in current directory, one can specify a non-existent file.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants