Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting error message #48

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

ericpre
Copy link
Contributor

@ericpre ericpre commented Mar 20, 2023

Noticed it in the following error message:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/nomad/normalizing/metainfo.py", line 35, in normalize_section
    normalize(self.entry_archive, logger)
  File "/usr/local/lib/python3.7/site-packages/nomad/datamodel/metainfo/eln/__init__.py", line 92, in normalize
    super(ElnBaseSection, self).normalize(archive, logger)
  File "/usr/local/lib/python3.7/site-packages/nomad/datamodel/data.py", line 82, in normalize
    super(EntryData, self).normalize(archive, logger)
  File "/usr/local/lib/python3.7/site-packages/nomad/parsing/tabular.py", line 103, in normalize
    self.tabular_parser(quantity_def, archive, logger, annotation)
  File "/usr/local/lib/python3.7/site-packages/nomad/parsing/tabular.py", line 130, in tabular_parser
    parse_columns(data, self)
  File "/usr/local/lib/python3.7/site-packages/nomad/parsing/tabular.py", line 284, in parse_columns
    'The sheet name {sheet_name} doesn''t exist in the excel file')
ValueError: The sheet name {sheet_name} doesnt exist in the excel file

Even if this is not used in this specific case, I removed the use of f-string with the logger, as this pattern is discouraged.

@markus1978
Copy link
Member

Thanks for the PR. The change makes sense. Please have some patience as we are still figuring out how to deal with these PRs and our two git-repositories.

@markus1978
Copy link
Member

I will close and reopen the PR and try to trigger our new sync with the GitLab.

@markus1978 markus1978 closed this Mar 24, 2023
@markus1978 markus1978 reopened this Mar 24, 2023
@github-actions
Copy link

A merge request has been opened on gitlab. View the GitLab merge requests.
This will run CI/CD pipelines, we will continue the discussion, and
merge on GitLab. After the merge has completed on GitLab, the changes will
be pushed to develop here.

@markus1978 markus1978 merged commit b452e06 into nomad-coe:develop Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants