New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Swift #178

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@sinoru

sinoru commented Jan 7, 2015

Hi!

This tool is really nice that can distribute to many places or iTunes Connect directly.
BUT, It doesn't support when swift codes are in.

I really want to use iTunes Connect distribution with this tool even though using Swift.
So I'm looking into it.

I found that Xcode Command Line tools doesn't contains SwiftSupport folder when PackageApplication it.
And, SwiftSupport folder is located in Xcode Archive.

So this commits make shenzhen will do archive action and embed SwiftSupport folder directly.
With this, I uploaded app to iTunes Connect successfully, and can distribute it through TestFlight by Apple.

Thanks!

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Jan 7, 2015

Contributor

Wow, this looks really good. Does that mean, you didn't have to change anything for uploading the ipa file, but only have to update the way, the app is packed inside the ipa?

Some users experienced the same problem when using deliver: fastlane-old/deliver#42

Thanks for sharing your solution @sinoru 👍

Contributor

KrauseFx commented Jan 7, 2015

Wow, this looks really good. Does that mean, you didn't have to change anything for uploading the ipa file, but only have to update the way, the app is packed inside the ipa?

Some users experienced the same problem when using deliver: fastlane-old/deliver#42

Thanks for sharing your solution @sinoru 👍

@KrauseFx KrauseFx referenced this pull request Jan 7, 2015

Merged

Fix Swift project handling #22

@sinoru

This comment has been minimized.

Show comment
Hide comment
@sinoru

sinoru Jan 7, 2015

@KrauseFx I just added last process that add SwiftSupport folder in ipa file. Never touch on {Application.app}.

Previous ipa structure looks like:

Payload/{Application.app}

After adding SwiftSupport ipa structure looks like:

Payload/{Application.app}
SwiftSupport/{SwiftLibraryFilesWhichUsedInApp.dylib}

After that, uploading this ipa to iTunes Connect, and it success.

But, I only found SwiftSupport folder in Xcode Archive.
So I add that process in ipa build, and change ipa build do archive aciton.

sinoru commented Jan 7, 2015

@KrauseFx I just added last process that add SwiftSupport folder in ipa file. Never touch on {Application.app}.

Previous ipa structure looks like:

Payload/{Application.app}

After adding SwiftSupport ipa structure looks like:

Payload/{Application.app}
SwiftSupport/{SwiftLibraryFilesWhichUsedInApp.dylib}

After that, uploading this ipa to iTunes Connect, and it success.

But, I only found SwiftSupport folder in Xcode Archive.
So I add that process in ipa build, and change ipa build do archive aciton.

@DarthMike

This comment has been minimized.

Show comment
Hide comment
@DarthMike

DarthMike Jan 12, 2015

@sinoru Could you please merge master into this branch? I'm trying to test your changes in my app by referencing your fork/branch in my Gemfile, but then other dependencies complain because you don't have latest version in .gemspec.

Thanks!

DarthMike commented Jan 12, 2015

@sinoru Could you please merge master into this branch? I'm trying to test your changes in my app by referencing your fork/branch in my Gemfile, but then other dependencies complain because you don't have latest version in .gemspec.

Thanks!

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Jan 12, 2015

Contributor

@DarthMike The latest released version is 0.10.3. You mean, @sinoru should update the version.rb to 0.10.13 as well, to make use of it, right? If you're talking about fastlane, you can modify the fastlane.gemspec and change it to an earlier version to make it work temporary.

Only @mattt can merge pull requests into master

Contributor

KrauseFx commented Jan 12, 2015

@DarthMike The latest released version is 0.10.3. You mean, @sinoru should update the version.rb to 0.10.13 as well, to make use of it, right? If you're talking about fastlane, you can modify the fastlane.gemspec and change it to an earlier version to make it work temporary.

Only @mattt can merge pull requests into master

@DarthMike

This comment has been minimized.

Show comment
Hide comment
@DarthMike

DarthMike Jan 12, 2015

@KrauseFx Yes I meant what you describe: Update @sinoru's master from upstream, and merge master into the pull request branch. Regarding fastlane, I did exactly that for test purposes. Thanks!

DarthMike commented Jan 12, 2015

@KrauseFx Yes I meant what you describe: Update @sinoru's master from upstream, and merge master into the pull request branch. Regarding fastlane, I did exactly that for test purposes. Thanks!

@sinoru

This comment has been minimized.

Show comment
Hide comment
@sinoru

sinoru Jan 13, 2015

I merged new 0.10.3 master to my branch. It might give some helps. I think.

sinoru commented Jan 13, 2015

I merged new 0.10.3 master to my branch. It might give some helps. I think.

@DarthMike

This comment has been minimized.

Show comment
Hide comment
@DarthMike

DarthMike commented Jan 13, 2015

Thanks!

@lvillani

This comment has been minimized.

Show comment
Hide comment
@lvillani

lvillani Jan 25, 2015

Contributor

JFYI: I'm working on a patch that works in a different way, is less slightly less intrusive than this one, works transparently regardless of whether or not the developer is building a Swift project and, most importantly, doesn't change the way the .ipa gets built.

I'll submit a pull request as soon as I confirm that it works fine for iTunes uploads.

Contributor

lvillani commented Jan 25, 2015

JFYI: I'm working on a patch that works in a different way, is less slightly less intrusive than this one, works transparently regardless of whether or not the developer is building a Swift project and, most importantly, doesn't change the way the .ipa gets built.

I'll submit a pull request as soon as I confirm that it works fine for iTunes uploads.

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Jan 26, 2015

Contributor

@lvillani Looking forward to it, thanks for working on a fix 👍

Contributor

KrauseFx commented Jan 26, 2015

@lvillani Looking forward to it, thanks for working on a fix 👍

@mattt

This comment has been minimized.

Show comment
Hide comment
@mattt

mattt Feb 27, 2015

Contributor

Thanks for your work on this, @sinoru. I decided to go with the approach used with #192 to add Swift support, which is now in the latest version.

Contributor

mattt commented Feb 27, 2015

Thanks for your work on this, @sinoru. I decided to go with the approach used with #192 to add Swift support, which is now in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment