Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing web3 for ethers.js #5

Closed
alcuadrado opened this issue May 28, 2018 · 4 comments
Closed

Consider replacing web3 for ethers.js #5

alcuadrado opened this issue May 28, 2018 · 4 comments

Comments

@alcuadrado
Copy link
Member

Most of buidler's instability comes from using web3, and in particular web3-provider-engine.

We should consider using ethers.js instead. We could create an ethers-powered web3 shim if necessary.

I haven't had enough time to experiment on this yet, but I think it's a promising idea. Still, it would be a big change, so I'll like to get some feedback about it.
@alcuadrado alcuadrado mentioned this issue May 28, 2018
Closed
@federicobond
Copy link
Contributor

I'm all for moving towards ethers.js as long as we provide compatibility with people using web3 too. Projects already on Truffle should be able to migrate their tests suites with relatively low friction.

@alcuadrado
Copy link
Member Author

Agree! I created #6 to discuss how to approach that.

@alcuadrado
Copy link
Member Author

I found this web3 compatibility layer already implemented by the author of ethers.js https://github.com/ethers-io/ethers-web3-bridge 🙌🏻

@alcuadrado alcuadrado mentioned this issue Aug 7, 2018
Closed
@alcuadrado
Copy link
Member Author

We are migrating to ethers.js

alcuadrado pushed a commit that referenced this issue Jun 3, 2020
@wighawag
Merge pull request #5 from nomiclabs/development
5c39900 
update
fvictorio pushed a commit that referenced this issue Dec 10, 2020
Mine blocks in a way that doesn't affect the gasleft() value (#5)
5fca3a2 
* Add getters for block.gaslimit and gasleft() values to test contract

* Remove duplicated deployContract function in evm module tests

* Create a failing test showing that gasleft() value is affected

* Make _runTx method not change the tx gasLimit value

* Fix lint
alcuadrado pushed a commit that referenced this issue May 27, 2022
@Kragov @usulpro
created VibrantCommunityBlock component (#5)
083ba42 
* created VibrantCommunityBlock component

* Move color to theme, Add secondary button styles for CTA

* Fix lint errors
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@federicobond @alcuadrado