Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: on_x 支持 expire_time 参数 #1106

Merged
merged 7 commits into from
Jul 20, 2022

Conversation

Dobiichi-Origami
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1106 (dc7a75c) into master (19f4c01) will increase coverage by 0.69%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
+ Coverage   78.08%   78.78%   +0.69%     
==========================================
  Files          42       42              
  Lines        3181     3182       +1     
==========================================
+ Hits         2484     2507      +23     
+ Misses        697      675      -22     
Flag Coverage Δ
unittests 78.78% <33.33%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/__init__.py 100.00% <ø> (ø)
nonebot/plugin/__init__.py 96.72% <ø> (ø)
nonebot/plugin/on.py 33.33% <20.00%> (+0.39%) ⬆️
nonebot/internal/matcher.py 96.34% <100.00%> (ø)
nonebot/message.py 38.46% <0.00%> (+16.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f4c01...dc7a75c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2022

🚀 Deployed on https://deploy-preview-1106--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 19, 2022 08:19 Inactive
Well2333
Well2333 previously approved these changes Jul 19, 2022
@yanyongyu yanyongyu added the enhancement New feature or request label Jul 19, 2022
MingxuanGame
MingxuanGame previously approved these changes Jul 19, 2022
Copy link
Member

@yanyongyu yanyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把CommandGroup的docstring也改一下吧,kwargs现在应该改成具体的参数了

@yanyongyu yanyongyu changed the title Feature: on_函数族支持 expire_time 参数 Feature: on_x 支持 expire_time 参数 Jul 19, 2022
@github-actions github-actions bot temporarily deployed to pull request July 19, 2022 10:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 20, 2022 01:36 Inactive
yanyongyu
yanyongyu previously approved these changes Jul 20, 2022
@github-actions github-actions bot temporarily deployed to pull request July 20, 2022 02:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 20, 2022 02:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 20, 2022 02:18 Inactive
@yanyongyu yanyongyu merged commit c03b0c7 into nonebot:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants