Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bot __getattr__ 不再对 __xxx__ 方法返回 #1398

Merged
merged 2 commits into from
Nov 19, 2022

Conversation

synodriver
Copy link
Member

不要截胡魔术方法,不然可能发生坏事

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1398 (4555258) into master (6b43209) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
- Coverage   85.87%   85.82%   -0.06%     
==========================================
  Files          41       41              
  Lines        3235     3237       +2     
==========================================
  Hits         2778     2778              
- Misses        457      459       +2     
Flag Coverage Δ
unittests 85.82% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/internal/adapter/bot.py 44.77% <0.00%> (-1.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

🚀 Deployed on https://deploy-preview-1398--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 16, 2022 08:21 Inactive
@yanyongyu yanyongyu added the bug Something isn't working label Nov 16, 2022
nonebot/internal/adapter/bot.py Outdated Show resolved Hide resolved
@synodriver
Copy link
Member Author

改好了

@github-actions github-actions bot temporarily deployed to pull request November 19, 2022 07:22 Inactive
@yanyongyu yanyongyu changed the title __getattr__ should not response to special methods Fix: Bot __getattr__ 不再对 __xxx__ 方法返回 Nov 19, 2022
@yanyongyu yanyongyu merged commit 0eadb44 into nonebot:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

2 participants