Added code to deal with sending large regions to the inferior process. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a long standing problem in emacs with sending large strings via comint. See (http://stackoverflow.com/questions/5541622/comint-mode-inserts-line-break-every-4096-characters) for some reference. This can cause a problem if for instance you have a variable value being initialied to a large string. You will receive an error like : > irb(main):122:0> > SyntaxError: /home/mdwyer/Desktop/CarTalk/download.rb:6: unterminated string meets end of file > from (irb):122:in `eval' > from (irb):122 > from /usr/bin/irb:12:in `<main>' This patch adds code to `ruby-send-region` that pages the input to be sent every `comint-max-input-size` characters. Each page is terminated with a newline which works around the comint bug. The newline is swallowed by comint, so no extraneous newlines are sent to the inferior process.
There is a long standing problem in emacs with sending large strings via comint. See (http://stackoverflow.com/questions/5541622/comint-mode-inserts-line-break-every-4096-characters) for some reference. This can cause a problem if for instance you have a variable value being initialied to a large string. You will receive an error like : > irb(main):122:0> > SyntaxError: /home/mdwyer/Desktop/CarTalk/download.rb:6: unterminated string meets end of file > from (irb):122:in \`eval' > from (irb):122 > from /usr/bin/irb:12:in \`<main>' This patch adds code to `ruby-send-region` that pages the input to be sent every `comint-max-input-size` characters. Each page is terminated with `comint-send-eof`, which works around the comint bug.
|
Please excuse my late response. I'm getting a On which OS/Ruby platform did you test the patch? (For me: Ubuntu 12.04, Emacs 24.3.1) |
|
No problem! I was on Ubuntu 13.04, default ruby (I think 1.9.1). I don't have access to that machine at the moment, but I will try your test file and get you better info add soon add I can! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a long standing problem in emacs with sending large strings via comint.
See (http://stackoverflow.com/questions/5541622/comint-mode-inserts-line-break-every-4096-characters)
for some reference. This can cause a problem if for instance you have a
variable value being initialied to a large string. You will receive an error
like :
This patch adds code to
ruby-send-regionthat pages the input to be sent everycomint-max-input-sizecharacters. Each page is terminated with a newlinewhich works around the comint bug. The newline is swallowed by comint, so no
extraneous newlines are sent to the inferior process.