🧹 Fix event api export_activity_log reply schema #7087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baum
force-pushed
the
export_activity_log
branch
from
fa11cf3
to
c56b94b
Compare
dannyzaken
approved these changes
Oct 20, 2022
baum
force-pushed
the
export_activity_log
branch
from
c56b94b
to
4f20f1b
Compare
Test:
➜ noobaa-operator git:(6f571fd) ✗ ./build/_output/bin/noobaa-operator-local -n noobaa api events_api export_activity_log '{}'
INFO[0000] ✅ Exists: NooBaa "noobaa"
INFO[0000] ✅ Exists: Service "noobaa-mgmt"
INFO[0000] ✅ Exists: Secret "noobaa-operator"
INFO[0000] ✅ Exists: Secret "noobaa-admin"
INFO[0000] ✈️ RPC: events.export_activity_log() Request: map[]
WARN[0000] RPC: GetConnection creating connection to wss://localhost:63468/rpc/ 0xc000b9fc20
INFO[0000] RPC: Connecting websocket (0xc000b9fc20) &{RPC:0xc0003659a0 Address:wss://localhost:63468/rpc/ State:init WS:<nil> PendingRequests:map[] NextRequestID:0 Lock:{state:1 sema:0} ReconnectDelay:0s cancelPings:<nil>}
INFO[0000] RPC: Connected websocket (0xc000b9fc20) &{RPC:0xc0003659a0 Address:wss://localhost:63468/rpc/ State:init WS:<nil> PendingRequests:map[] NextRequestID:0 Lock:{state:1 sema:0} ReconnectDelay:0s cancelPings:<nil>}
ERRO[0001] RPC: HandleResponse for OP res API raw bytes {"op":"res","reqid":"wss://localhost:63468/rpc/-0","took":898.633090000134,"reply":{"out_path":"/public/audit.csv"}}
INFO[0001] ✅ RPC: events.export_activity_log() Response OK: took 898.6ms
out_path: /public/audit.csv
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
baum
force-pushed
the
export_activity_log
branch
from
4f20f1b
to
14dcce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix event api export_activity_log reply schema
Issue:
Test:
➜ noobaa-operator git:(6f571fd) ✗ ./build/_output/bin/noobaa-operator-local -n noobaa api events_api export_activity_log '{}' INFO[0000] ✅ Exists: NooBaa "noobaa"✈️ RPC: events.export_activity_log() Request: map[] WARN[0000] RPC: GetConnection creating connection to wss://localhost:63468/rpc/ 0xc000b9fc20 INFO[0000] RPC: Connecting websocket (0xc000b9fc20) &{RPC:0xc0003659a0 Address:wss://localhost:63468/rpc/ State:init WS: PendingRequests:map[] NextRequestID:0 Lock:{state:1 sema:0} ReconnectDelay:0s cancelPings:} INFO[0000] RPC: Connected websocket (0xc000b9fc20) &{RPC:0xc0003659a0 Address:wss://localhost:63468/rpc/ State:init WS: PendingRequests:map[] NextRequestID:0 Lock:{state:1 sema:0} ReconnectDelay:0s cancelPings:} ERRO[0001] RPC: HandleResponse for OP res API raw bytes {"op":"res","reqid":"wss://localhost:63468/rpc/-0","took":898.633090000134,"reply":{"out_path":"/public/audit.csv"}} INFO[0001] ✅ RPC: events.export_activity_log() Response OK: took 898.6ms out_path: /public/audit.csv
INFO[0000] ✅ Exists: Service "noobaa-mgmt"
INFO[0000] ✅ Exists: Secret "noobaa-operator"
INFO[0000] ✅ Exists: Secret "noobaa-admin"
INFO[0000]
Signed-off-by: Alexander Indenbaum aindenba@redhat.com