Add Region to Connection Schemas + Use Region in Check Connection

[shirady]

Explain the changes

1. Add region to connection schemas.
2. Use region in check_aws_connection.

Issues: Fixed #xxx / Gap #xxx

1. none

Testing Instructions:

Need to build with operator change noobaa/noobaa-operator#1188.

1. Deploy noobaa on MInikube or Rancher Desktop (see guide).
   Note: nb is an alias that runs the local operator from build/_output/bin (alias created by devenv).
2. Create namespacestore/backingstore and pass the region explicitly:
   nb namespacestore create aws-s3 <namespace-store-name> --region=<target-bucket-region>.
   nb backingstore create aws-s3 <backingstore-store-name> --region=<target-bucket-region>.
3. Add printings to check_external_connection, check_aws_connection and see that the region passed.
   Note: test on buckets in the regions 'us-east-1' and 'us-west-1'.

• Doc added/updated
• Tests added

[Neon-White]

Looks good, just one question - is there a reason that the region attribute is added to the connection only in update_external_connection and not in add_external_connection as well?

[shirady]

Looks good, just one question - is there a reason that the region attribute is added to the connection only in update_external_connection and not in add_external_connection as well?

@Neon-White, Would you please mark the line where you think I didn't add the region attribute?

I'll try to explain although I'm not sure what you meant exactly:
In add_external_connection schema the region was already set - see account.api lines 415-417:

noobaa-core/src/api/account_api.js

Lines 415 to 417 in 7ffb2e6

	region: {
	type: 'string'
	},

But in the function add_external_connection(req) we didn't extract the region from req, and I added it in line 717 (see it in the files changes, this was the original line):

noobaa-core/src/server/system_services/account_server.js

Line 717 in 7ffb2e6

let info = _.pick(req.rpc_params, 'name', 'endpoint', 'endpoint_type', 'aws_sts_arn');

and eventually, the info that would contain the region will be saved in the DB (we add the region to info and it will be saved under sync_credentials_cache):

noobaa-core/src/server/system_services/account_server.js

Lines 752 to 759 in 7ffb2e6

	await system_store.make_changes({
	update: {
	accounts: [{
	_id: req.account._id,
	$push: { sync_credentials_cache: info }
	}]
	}
	});

[Neon-White]

Thank you for the thorough explanation!