Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Note: It's something I missed in PR Add Region to Connection Schemas + Use Region in Check Connection #7433 - here we check that it passed to namespace s3.
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
Note:
nb
is an alias that runs the local operator frombuild/_output/bin
(alias created bydevenv
).nb namespacestore create aws-s3 <namespace-store-name> --region=<target-bucket-region>
.nb bucketclass create namespace-bucketclass single <bucket-class-name> --resource=<namespace-store-name>
nb obc create <obc-name> --bucketclass=<bucket-class-name>
kubectl port-forward -n default service/s3 12443:443
alias s3-user-1='AWS_SECRET_ACCESS_KEY=<paste-here> AWS_ACCESS_KEY_ID=<paste-here> aws --no-verify-ssl --endpoint-url https://localhost:12443'
s3-user-1 s3api head-object --bucket <bucket-name> --key <key-name>
_setup_single_namespace
(printr.region
) see that the region passed.