Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Region For Namespace S3 #7489

Merged

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Sep 13, 2023

Explain the changes

  1. Pass region for namespace s3 (not using it yet).
    Note: It's something I missed in PR Add Region to Connection Schemas + Use Region in Check Connection #7433 - here we check that it passed to namespace s3.

Issues: Fixed #xxx / Gap #xxx

  1. none

Testing Instructions:

  1. Deploy noobaa on MInikube or Rancher Desktop (see guide).
    Note: nb is an alias that runs the local operator from build/_output/bin (alias created by devenv).
  2. Create namespacestore and pass the region explicitly:
    nb namespacestore create aws-s3 <namespace-store-name> --region=<target-bucket-region>.
  3. Create bucket class:
    nb bucketclass create namespace-bucketclass single <bucket-class-name> --resource=<namespace-store-name>
  4. Create OBC:
    nb obc create <obc-name> --bucketclass=<bucket-class-name>
  5. Use the alias from previous step and run s3 operation, for example:
    kubectl port-forward -n default service/s3 12443:443
    alias s3-user-1='AWS_SECRET_ACCESS_KEY=<paste-here> AWS_ACCESS_KEY_ID=<paste-here> aws --no-verify-ssl --endpoint-url https://localhost:12443'
    s3-user-1 s3api head-object --bucket <bucket-name> --key <key-name>
  6. After adding printings to _setup_single_namespace (print r.region) see that the region passed.
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Sep 14, 2023
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the add-region-to-namespace-connection-info branch from 7d0590e to 702fee3 Compare September 19, 2023 09:33
@shirady shirady merged commit e78842b into noobaa:master Sep 19, 2023
8 checks passed
@shirady shirady deleted the add-region-to-namespace-connection-info branch September 28, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants