docker build - bump base image to centos stream 9 #7571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
reviewed
Nov 8, 2023
liranmauda
approved these changes
Nov 9, 2023
dannyzaken
reviewed
Nov 9, 2023
| @@ -13,7 +13,7 @@ | |||
| 's3select_napi.cpp' | |||
| ], | |||
| 'link_settings': { | |||
| 'libraries': ['/lib64/libboost_thread.so.1.66.0'] | |||
| 'libraries': ['/lib64/libboost_thread.so.1.75.0'] | |||
There was a problem hiding this comment.
@alphaprinz @liranmauda, does this affect downstream builds?
There was a problem hiding this comment.
Good catch, I've asked Boris.
I think we need to work with a softlink so that specific version won't matter?
There was a problem hiding this comment.
Downstream is based on RHEL 9 since 5.13
@b-ranto Will this change effect Downstream? maybe we can have a private build to test is. WDYT?
There was a problem hiding this comment.
It won't, we use a hack that manually update the version to the one in RHEL 9:
https://pkgs.devel.redhat.com/cgit/containers/mcg-core/tree/Dockerfile?h=rhodf-4.13-rhel-9#n29
i.e. we have had this patch applied downstream for a while now. :-)
b-ranto
approved these changes
Nov 13, 2023
alphaprinz
force-pushed
the
centos9
branch
2 times, most recently
from
8738ff5
to
2d4ec23
Compare
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: