Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Actions | fix RHEL 9 rpm suffix #7607

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. docker build was bumped base image to RHEL9 in docker build - bump base image to centos stream 9 #7571, so the rpm suffix should be updated as well.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@liranmauda
Copy link
Contributor

@romayalon @tangledbytes
Few questions here:

  1. Is the RPM really bound to a specific RHEL version?
  2. Will the RPM work on both RHEL 8 and RHEL 9?

In the case that it is not bound, we can remove the suffix of the OC

We need to ensure we support RHEL 9 and RHEL 8.

@romayalon
Copy link
Contributor Author

@liranmauda As I mentioned on slack, currently it only builds RHEL9, if we want to support both RHEL8 and RHEL9 this change #7571 should be reverted and we should make it configurable by the user. the issue is that there was no nightly rpm build since this change was merged.

@liranmauda
Copy link
Contributor

I don't think we should revert, We should only patch the single line that changes the 'libraries': ['/lib64/libboost_thread.so.1.75.0']
We should do it dynamically, On RHEL9 keep it, and on RHEL 8 change it to 1.66 back.
We should also use the correct base for supporting both RHEL versions.

Opened: #7608

In this PR case, we should keep the RHEL version in the RPM name, and el9 represents it correctly.

@romayalon romayalon merged commit 116848f into noobaa:master Nov 20, 2023
9 checks passed
@romayalon
Copy link
Contributor Author

@liranmauda In any case, make rpm and the affected actions should be changed when we have both RHEL8 and RHEL9 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants