Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding namespace to secretRef from the backingstore or namespacestore when it is missing #914

Merged
merged 1 commit into from May 16, 2022
Merged

Adding namespace to secretRef from the backingstore or namespacestore when it is missing #914

merged 1 commit into from May 16, 2022

Conversation

liranmauda
Copy link
Contributor

@liranmauda liranmauda commented May 12, 2022 •
edited

Explain the changes

Adding namespace to secretRef from the backingstore or namespacestore when it is missing

Signed-off-by: liranmauda liran.mauda@gmail.com

Issues:

  1. https://bugzilla.redhat.com/show_bug.cgi?id=2084201

Gap:

  1. We want to add webhooks to avoid create of backingstore with a secret ref without a namespace

@liranmauda liranmauda force-pushed the liran-fix-default-secret-namespace branch from f074279 to 26dfabe Compare May 12, 2022 13:01
@liranmauda liranmauda force-pushed the liran-fix-default-secret-namespace branch from 26dfabe to a0746f3 Compare May 12, 2022 13:46
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 12, 2022
@liranmauda liranmauda force-pushed the liran-fix-default-secret-namespace branch from a0746f3 to 0145ee0 Compare May 12, 2022 13:53
@liranmauda liranmauda changed the title Using a defaultSecretNamespace for backingstore and namespacestore Adding namespace to secretRef from the backingstore or namespacestore when it is missing May 12, 2022
@liranmauda liranmauda force-pushed the liran-fix-default-secret-namespace branch from 0145ee0 to bb7b6ff Compare May 15, 2022 06:30
@liranmauda
when there is no secretRef.Namespace adding it from the backingstore …
50f13b9 
…or namespacestore

when there is no secretRef.Namespace adding it from the backingstore or namespacestore

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda force-pushed the liran-fix-default-secret-namespace branch from bb7b6ff to 50f13b9 Compare May 15, 2022 11:41
@liranmauda liranmauda merged commit 8e99504 into noobaa:master May 16, 2022
@liranmauda liranmauda mentioned this pull request May 30, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

@kfir-payne kfir-payne kfir-payne approved these changes

@romayalon romayalon Awaiting requested review from romayalon

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liranmauda @dannyzaken @kfir-payne