Adding secretef Webhook For Backingstore and Namespacestore #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dannyzaken @kfir-payne please take a look. |
liranmauda
force-pushed
the
liran-secretRef-Namespace-webhook
branch
from
9e26122
to
e79b7dc
Compare
kfir-payne
reviewed
Sep 13, 2022
| @@ -92,6 +92,10 @@ func (nsv *ResourceValidator) ValidateUpdateNS() { | |||
| nsv.SetValidationResult(false, err.Error()) | |||
| return | |||
| } | |||
| if err := validations.ValidateNamespacestoreSecretRefNamespace(*ns); err != nil && util.IsValidationError(err) { | |||
There was a problem hiding this comment.
I think that the call for ValidateNamespacestoreSecretRefNamespace should be inside ValidateNamespaceStore function, that way this validation will be checked in creation ops as well.
| func ValidateBackingstoreSecretRefNamespace(bs nbv1.BackingStore) error{ | ||
| secretRef, err := util.GetBackingStoreSecretByType(&bs); | ||
| if err != nil { | ||
| return util.ValidationError{ |
There was a problem hiding this comment.
This is not a validation error, it's an error in the retrieval of the Backingstore secret reference.
same goes for Namespacestore.
- Adding secretef Webhook For Backingstore and Namespacestore to validate that it have namespace in it. Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
force-pushed
the
liran-secretRef-Namespace-webhook
branch
from
e79b7dc
to
d9fead1
Compare
|
@liranmauda I think that for now we can skip the webhook validation for that. let's close |
Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Closing the gap from #914
Signed-off-by: liranmauda liran.mauda@gmail.com
Issues:
Testing Instructions: